feat(ci): add GitHub Actions workflow and Makefile for deploy_gcp#30
Merged
feat(ci): add GitHub Actions workflow and Makefile for deploy_gcp#30
Conversation
Adds a `check` workflow (push to main, all PRs) that runs `make check`, which wraps `ruff check`, `ruff format --check`, and `ty check` against the `deploy_gcp` package. uv picks up the Python version from `.python-version`. Also clears the lint/format/type debt in `deploy_gcp` so the workflow is green on day one: - B904 `raise ... from e` on re-raised exceptions - E501/B007 line-length and unused loop var fixes - `ruff format` applied across the package - narrow `state.public_ip: str | None` with asserts at use sites - cast around seismic_web3's `PrivateKey.__new__` stub bug - `# ty: ignore` for the runtime-attached `w3.seismic` attribute - `dict[str, Any]` for pydantic kwargs in DeploymentConfig.from_conf_file `deploy_tee` is intentionally out of scope; it has its own lint/type debt that will be cleaned up in a follow-up PR before being added to the workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
checkworkflow (push to main, all PRs) that runsmake check, which wrapsruff check,ruff format --check, andty checkagainst thedeploy_gcppackage. uv picks up the Python version from.python-version.Also clears the lint/format/type debt in
deploy_gcpso the workflow is green on day one:raise ... from eon re-raised exceptionsruff formatapplied across the packagestate.public_ip: str | Nonewith asserts at use sitesPrivateKey.__new__stub bug# ty: ignorefor the runtime-attachedw3.seismicattributedict[str, Any]for pydantic kwargs in DeploymentConfig.from_conf_filedeploy_teeis intentionally out of scope; it has its own lint/type debt that will be cleaned up in a follow-up PR before being added to the workflow.